Skip to content

fix: Add Serializable and NonSerialized attributes#3882

Merged
NoelStephensUnity merged 12 commits intodevelop-2.0.0from
fix/missing-serializable-attribute
Mar 4, 2026
Merged

fix: Add Serializable and NonSerialized attributes#3882
NoelStephensUnity merged 12 commits intodevelop-2.0.0from
fix/missing-serializable-attribute

Conversation

@noellie-velez
Copy link
Collaborator

Purpose of this PR

Fixing CI compilation error for 6000.5

Jira ticket

N/A

Changelog

N/A

Documentation

  • No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

  • Manual testing done

Automated tests:

  • Covered by existing automated tests
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?
  • Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Backports

@noellie-velez noellie-velez requested a review from a team as a code owner March 2, 2026 10:23
noellie-velez and others added 5 commits March 2, 2026 11:33
Marking all of the fields that Roslyn is complaining about as internal.
Reverting some changes.
Adding NETCODE_UAC1001_CHECKS (for now) wrapped [Serializable] decorations to anything that is public and not already considered serializable.
Removing trailing spaces.
No need to make this [Serializable]
Removing using directive no loner needed.
Wrapping the added using directives.
Removing the NETCODE_UAC1001_CHECKS
reverting internal
Copy link
Member

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good to me (and I am done fiddling with it... 😺 )

@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) March 4, 2026 17:43
@NoelStephensUnity NoelStephensUnity merged commit a762d7d into develop-2.0.0 Mar 4, 2026
20 of 21 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/missing-serializable-attribute branch March 4, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants